search

lunarmodules / luasql

LuaSQL is a simple interface from Lua to a DBMS.
http://lunarmodules.github.io/luasql
535 stars 192 forks source link

Github no longer supports "The unauthenticated git protocol on port 9418" #136

Closed timmipetit closed 5 months ago

timmipetit commented 2 years ago

Since today (Janary 11, 2022) Github no longer supports pulling from the git protocol on port 9418. This means that trying to install luasql using luarocks will result in an error:

luarocks install luasql-mysql 
Installing https://luarocks.org/luasql-mysql-2.6.0-1.rockspec
Cloning into 'luasql'...
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
Error: Failed cloning git repository.

I suspect that the rockspec files should be updated to a https:// url instead of a git:// url

denis-ignatenko commented 2 years ago

I suspect that the rockspec files should be updated to a https:// url instead of a git:// url

No it does not helps. Links must be git+https://github.com/keplerproject/luasql.git

timmipetit commented 2 years ago

Ah indeed, you are correct. For anyone else who has the same problem, we made a copy of the rockspec file from the repository, changed the source url to git+https://github.com/keplerproject/luasql.git, and then run luarocks install luasql-mysql-2.6.0-1.rockspec as a workaround.

fakhruddinhamid commented 2 years ago

https://github.blog/2021-09-01-improving-git-protocol-security-github/

As per this blog, git:// will stop working without authentication permanently on Mar 15 2022. Could a patch be released converting the URLs to git+https soon, so we get some time to test in our Env as well.

SlySven commented 2 years ago

This has happened and it means all the rocks from this repository are no longer available using the expected luarocks install luasql-xxxxx!

@tomasguisasola can you look into fixing this?

SlySven commented 2 years ago

GitHub seems stupid - I cannot see how to make a PR that would create a new branch that is based on the repository as it was at 22d4a911f35cf851af9db71124e3998d96fb3fa1 (which has the 2.6.0 tag) - the code is in my repository at https://github.com/SlySven/luasql/commit/ba89efa273177dbaba1e382d4b500ea97fe298c5 but I cannot see how to formulate a PR to get it into this repository!

tomasguisasola commented 5 months ago

Sorry for late response.

Fixed.