search

lunarmodules / luasql

LuaSQL is a simple interface from Lua to a DBMS.
http://lunarmodules.github.io/luasql
545 stars 190 forks source link

Fixed "unauthenticated git protocol" error #139

Closed hector-vido closed 2 years ago

hector-vido commented 2 years ago

Github disable the unauthenticated connection through SSH as we can see here:

https://github.blog/2021-09-01-improving-git-protocol-security-github/

I just changed every file to use https instead.

image

tst2005 commented 2 years ago

FYI, luarocks 3.8.0 support it without change (see https://github.com/luarocks/luarocks/commit/9ff512e35455939f02eaec2318e3acc77782fdeb )

hector-vido commented 2 years ago

Good to know. But is not a good a idea fix this to avoid problems with people using old versions?

This luarocks package is from Alpine 3.15 and the version is 2.4.4.

tst2005 commented 2 years ago

@hector-vido sure, fixing this is good for the futur but I'm just annoyed by an arbitrary change that breaks everything, especially when the blog asks everyone to fix it themselves. I was dreaming of being able to comment on this blog to provide workarounds, until all existing repositories are fixed (that is a huge work)! thanks github, thanks micros*ft!

Another workaround (without luarocks upgrade)

hector-vido commented 2 years ago

Sorry man, I just trying to help, I though this was a good idea because is simple, and I can't see why this change will break something. What blog you're talking about?

tst2005 commented 2 years ago

@hector-vido sorry I didn't mean to offend you. Don't take my answer against you. I see and understand you just want to help. I follow lot of lua projets and see plenty of issue like this one. I had to rant against github/microsoft. ( The blog I talk is https://github.blog/2021-09-01-improving-git-protocol-security-github/ )

hector-vido commented 2 years ago

Next time, please, tell me "I will not accept this because ..."