search

lunarmodules / luassert

Assertion library for Lua
MIT License
202 stars 77 forks source link

luassert 1.7.7 causes 100% CPU loop with awesomeWM's tests #118

Closed blueyed closed 9 years ago

blueyed commented 9 years ago

I've discovered that luassert 1.7.7 (pulled in by busted) caused a regression with make check for awesomeWM (initially reported at https://github.com/awesomeWM/awesome/issues/258).

TEST CASE:

  1. git clone https://github.com/awesomeWM/awesome
  2. cd awesome
  3. make check

(make sure to have busted and luassert >= 1.7.7 installed)

I have not checked if it's fixed in Git. Using luassert 1.7.6 works.

o-lim commented 9 years ago

I think this is fixed on the master branch. Can you try using the latest master to confirm?

blueyed commented 9 years ago

@o-lim Sure. How is this supposed to be done?

Can luarocks be installed from a Git checkout? Or do I have to adjust the Lua path?

o-lim commented 9 years ago

First remove busted (luarocks remove busted), then install the latest master of luassert by cloning luassert and do luarocks make inside the luassert repo. Then just re-install busted as usual (luarocks install busted).

blueyed commented 9 years ago

Yes, that fixes the issue!

It seems to be fixed with the first commit after v1.7.7 already: 4d76417

(although git-bisect had problems when I've tried to mark v1.7.7 as bad:)

Some good revs are not ancestor of the bad rev. git bisect cannot work properly in this case. Maybe you mistake good and bad revs?

o-lim commented 9 years ago

Sounds great. I guess that resolves this issue.