search

lunarmodules / luassert

Assertion library for Lua
MIT License
202 stars 76 forks source link

Format called and returned with args #165

Closed qha closed 3 years ago

qha commented 5 years ago

This pr closes #155 and Olivine-Labs/busted#578 and replaces #164.

qha commented 5 years ago

Obviously there is another outstanding issue too. It may be a week or two until i can resolve it.

qha commented 5 years ago

Nope, found it.

qha commented 4 years ago

I figured out how to check messages for failed assertions so the formatting questions are the only ones that remain, see above.

dav-is commented 4 years ago

Is there an update on this PR?

qha commented 4 years ago

Is there an update on this PR?

I presume this is directed at someone else but just in case i'm mistaken: I'm waiting for feedback on the outstanding issues still listed in the top comment or any other feedback on changes needed to get this merged.

qha commented 4 years ago

Thank you for your feedback! I will have a look at addressing your comments. I don't expect to find the time for that this week though, hopefully next week or the week after that.

qha commented 4 years ago

I found some time today for working on this pr.

Please review the updated commits and my comments in the conversations above!

jeduden commented 4 years ago

Looks like a fantastic feature to have. Is there any chance that this PR will be merged ?

Tieske commented 3 years ago

merged manually