Closed qha closed 3 years ago
Obviously there is another outstanding issue too. It may be a week or two until i can resolve it.
Nope, found it.
I figured out how to check messages for failed assertions so the formatting questions are the only ones that remain, see above.
Is there an update on this PR?
Is there an update on this PR?
I presume this is directed at someone else but just in case i'm mistaken: I'm waiting for feedback on the outstanding issues still listed in the top comment or any other feedback on changes needed to get this merged.
Thank you for your feedback! I will have a look at addressing your comments. I don't expect to find the time for that this week though, hopefully next week or the week after that.
I found some time today for working on this pr.
Please review the updated commits and my comments in the conversations above!
Looks like a fantastic feature to have. Is there any chance that this PR will be merged ?
merged manually
This pr closes #155 and Olivine-Labs/busted#578 and replaces #164.