search

lunarmodules / luassert

Assertion library for Lua
MIT License
202 stars 77 forks source link

cleanup unused locals and globals #2

Closed Tieske closed 12 years ago

Tieske commented 12 years ago

Please check the comments in 'all.lua'

It is a really bad piece of code. The module luassert was pulled out of busted for re-use, then it should be clean and not littering the global namespace with all sorts of globals.

see this commit as well; https://github.com/Tieske/busted/commit/33108eca84a3c17d6b7a8afc9ea957ba1fb9cee2

Tieske commented 12 years ago

ignore the previous comment, I already updated all.lua (and renamed it), this will do for 'a lua way of things'

ajacksified commented 12 years ago

This looks a whole lot cleaner. Before we had fully defined the API we were going to use, we wanted to register everything globally for ease of use (the way busted exposes describe, it, etc); this was kind of a leftover from that same design decision. We have some refactoring of busted to do to get it running with this, but I think this is definitely a big step forward.

We obviously just ripped it out of busted and haven't cleaned it up yet. Once we have the API solidified, I'm going to write docs for this and say as well.

DorianGray commented 12 years ago

Merged in! Thanks =)