search

lunarphp / livewire-starter-kit

Demonstration store for Lunar
https://docs.lunarphp.io/core/starter-kits.html
155 stars 51 forks source link

Installer wants to know whether to overwrite existing config #22

Open glennjacobs opened 2 years ago

glennjacobs commented 2 years ago

Not sure what the correct thing to do is? Is the commited config changed from default?

alecritson commented 2 years ago

There's a few changes such as order statuses, payment stuff and a bit on the cart I think.

glennjacobs commented 2 years ago

Any suggestions on how to solve this? As people will overwrite them for sure...

alecritson commented 2 years ago

Add a command to run i.e. demostore:install instead which does the GetCandy install but then copies across the config we need?

glennjacobs commented 2 years ago

My only concern with that is the developer isn't getting familiar with the getcandy command.

What if we run the demostore:install command after the getcandy one? Yes, it's an extra step.. but they're learning.

alecritson commented 2 years ago

Yeah, seems reasonable. Will see If I can get a PR done.

glennjacobs commented 1 year ago

@alecritson I see you closed your PR on this. Is this still an issue? If someone overwrites the config, will it cause uses on the demo store?