Support of Lunar 1.x - Githubissues

lunarphp / livewire-starter-kit

Demonstration store for Lunar

https://docs.lunarphp.io/core/starter-kits.html

149 stars 50 forks source link

Support of Lunar 1.x #86

Closed lguichard closed 1 week ago

lguichard commented 5 months ago

This PR is a draft to support Lunar 1.x version.

TODO :

[x] Support Docker
[x] Lando support
[x] Meilisearch support
[x] Meilisearch UI
[x] Redis
[x] Mailhog
[x] Livewire 3 support
[x] Fix database seeder
[x] Fix automatic install
[x] Remove webpack and add Vite
[x] Update dependencies
[x] Add shipping add-on and remove old logic
[x] Support Laravel 10.x
[x] Cleaning project
[x] Fix Livewire 3 issues in storefront
[x] Use wire:navigate
[x] Documentation

eugenefvdm commented 5 months ago

@lguichard I'm happy to tackle some of this?

Livewire 3 support Remove webpack and add Vite Update dependencies

I have some confidence in getting the work done because of some work I have done before:

Used php artisan livewire:upgrade and all seemed good, I selected yes for every single question including non default questions.
I've also shifted 0.8 to 1.x and this seemed to work perfectly
Used free Shift to do webpack (but this is easy with copy/paste of fresh Laravel)
Dependency updates doesn't seems that hard? Not sure what I'm missing here.

The only caveat so far I have found after all this work is that the ShippingManifest has an issue so not entirely sure if I should do all this work and hand over a complex ShippingManifest issue (which I couldn't solve).

lguichard commented 5 months ago

@eugenefvdm Thank you so much for your comprehensive informations that will help me.

I also convert a Lunar project to L10, i used same steps that you used

alecritson commented 5 months ago

Happy to of course also help on this.

With regard to the shipping issue I think that since 1.0 has the shipping tables add-on available it would make more sense to strip the existing logic in favour of using it.

This should mean the bulk of work needed would be to set up new shipping seeders and register the add-on.

Happy to take a look or happy for someone else too if they feel happy with the approach.

lguichard commented 5 months ago

@alecritson Nice !

You can help me to update Database Seeder, you know better than me the core. I would not like forgot something.

About the shipping logic i added a TODO.

alecritson commented 4 months ago

@lguichard I've pushed a commit which should hopefully take care of the shipping seeders, for now it just adds UK, Europe and US shipping zones and prices. ✌️

lguichard commented 4 months ago

@lguichard I've pushed a commit which should hopefully take care of the shipping seeders, for now it just adds UK, Europe and US shipping zones and prices. ✌️

Thx !

Now we have to ProductVariant generation & some tweaks

webpatser commented 4 months ago

I just tried this on a fresh v1 install, but there is something with the Carts that is broken.

I will try to hunt this down if you are not already on the case :-)

dotmbf commented 1 month ago

didnt know this existed, been toying with it a lot myself.

as i read the documentation of Livewire, is 'legacy_model_binding' => true really the "correct" fix for the model binding in this case? it seems to me that it's something that they expect to remove in future updates/releases (maybe 4.x, but who knows?)

ezequiel9 commented 1 month ago

Are you guys merging this anytime soon? I am about to start a project and would be great to start with 1.x . Thank you very much for your hard work on this.