Some texts don't have translations

lunarphp / lunar

An open-source package that brings the power of modern headless e-commerce functionality to Laravel.

https://lunarphp.io

MIT License

2.5k stars 321 forks source link

Some texts don't have translations #1152

Open rinodrummer opened 1 year ago

rinodrummer commented 1 year ago

Lunar version: 0.4
Laravel Version: 10.15.0
PHP Version: 8.1

While testing for Italian translation me and @sebhd1 noticed that most of the texts in packages/admin/resources/views/partials/forms/discount.blade.php are not using __() so there are no related entries in translation files.

sebhd1 commented 1 year ago

While going on testing, we also discovered that the translations are missing on the specified file: lunar/packages/admin/src/Menu/SettingsMenu.php.

glennjacobs commented 1 year ago

You may as well update them when doing your translation PR.

rinodrummer commented 1 year ago

You may as well update them when doing your translation PR.

Ok! Perfect!

We were worried about the conventions relative to the keys in the translation files, but we'll try our best to match the standards!

We will keep writing here where we spot issues just to keep track and then close the issue along with the PR we are going to open.