fix price breaks not storing in correct currency factor

lunarphp / lunar

An open-source package that brings the power of modern headless e-commerce functionality to Laravel.

https://lunarphp.io

MIT License

2.71k stars 357 forks source link

fix price breaks not storing in correct currency factor #1948

Closed wychoong closed 2 months ago

wychoong commented 2 months ago

also added ->required() to shipping method

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lunar-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 13, 2024 9:47am

alecritson commented 2 months ago

Thanks @wychoong Should we also be considering the Min. Spend field as well?

wychoong commented 2 months ago

Thanks @wychoong Should we also be considering the Min. Spend field as well?

Min. Spend field is actually min_quantity field on the table, and currently it is hardcoded to multiply 100. do you want me to update it to use currency factor too?

alecritson commented 2 months ago

I think so, since the shipping addon uses this as a price check 🤔

wychoong commented 2 months ago

I think so, since the shipping addon uses this as a price check 🤔

I have updated both to use the currency factor. Also fixed my previous change which uses default currency. now it uses the currency selected at the repeater 😶‍🌫️