Fix/shipping min quantity factor

lunarphp / lunar

An open-source package that brings the power of modern headless e-commerce functionality to Laravel.

https://lunarphp.io

MIT License

2.71k stars 357 forks source link

Open wychoong opened 2 months ago

wychoong commented 2 months ago

changes:

min_quantity now check on shipping method to determine should it divide by currency factor
min_quantity field label now reflect according to method
move min_quantity as last field
~now assume weight is by KG~

after

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lunar-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 11:22pm

maurice-ellis commented 2 months ago

Don't assume weight, we are imperial in the US

wychoong commented 1 month ago

Don't assume weight, we are imperial in the US

the focus of this PR is on the shipping method chargeBy is not considered when converting min_quantity

to properly calculate shipping cost for chargeBy weight requires more effort and should be a separate PR

wychoong commented 1 month ago

changed it back to min_quantity / 100 for weight so that it is same as previous behavior