search

lunarphp / lunar

An open-source package that brings the power of modern headless e-commerce functionality to Laravel.
https://lunarphp.io
MIT License
2.71k stars 357 forks source link

doc: add remark for custom model definition #1966

Closed wychoong closed 9 hours ago

wychoong commented 1 month ago

when a Lunar model is extended/replaced, the media definition config should be updated. Or standard definition will be used

p/s: not sure should the media definition to change to string alias or internally auto resolve to lunar model fqcn

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:25am
alecritson commented 1 month ago

I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense.

wychoong commented 1 month ago

I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense.

Totally agree. In config you prefer alias or fqcn?

alecritson commented 2 weeks ago

I think it would be more beneficial if the media definition worked with extended models. My thinking is that you should be able to just remove model extending in one place without having to then update a bunch of config etc in order to remove it if that makes sense.

Totally agree. In config you prefer alias or fqcn?

I think alias should be sufficient since that's set up by Lunar so unlikely to cause issues and maybe less confusing for people using extending.

wychoong commented 1 day ago

alias should be sufficient

done