redesign quick view to be a provider and use query params

lunasec-io / lunasec

LunaSec - Dependency Security Scanner that automatically notifies you about vulnerabilities like Log4Shell or node-ipc in your Pull Requests and Builds. Protect yourself in 30 seconds with the LunaTrace GitHub App: https://github.com/marketplace/lunatrace-by-lunasec/

https://www.lunasec.io/

Other

1.44k stars 164 forks source link

redesign quick view to be a provider and use query params #1133

Open factoidforrest opened 1 year ago

factoidforrest commented 1 year ago

This is the CORRECT implementation of the quick-view system, that I should have written from the start.

The two main changes are:

to use a provider to hold this state instead of the gnarly prop drilling.
to use the query string in the URL to track the quick view state. Really nice because people can link to quick views now.

This was needed before we started porting quick view to other parts of the app, as is planned for vuln search.