search

lunatech-labs / lunatech-competence-center-online

CCO is the Competence Center Online.
3 stars 3 forks source link

Fix pdf generator to use dates #15

Open ag91 opened 7 years ago

ag91 commented 7 years ago

The commits in #13 added date fields, but didn't update the backend to use the date format.

wjglerum commented 7 years ago

We had them as data values in the xml first however we changed back to string values because we also used things like NOW, 2017, MAY 2017so how are we going to handle those? Or should we format in the backend the dates we get from the frontend?

erikwj commented 7 years ago

In the json -> xml transformation the dates get transferred to strings. Eventually we can give the format in the CV metadata, for a MVP we'll use 1 way of converting it, something like if(enddate == undefined) translate("NOW") else formatData("MM YYYY", language) This gives flexibility to update the format of the CV, make it easier in bilingual setting etc. I'll clarify later.