Handle errors about third party download and extract

lunchclass / absolute

Absolute is a web-based O2O(Online to Offline) platform like Siren-Order for Starbucks. We are focused on creating the platform that is portable, cheaper, easier, decentralized and appless.

Apache License 2.0

103 stars 31 forks source link

Handle errors about third party download and extract #543

Closed cs-lee closed 6 years ago

cs-lee commented 6 years ago

If script fail to download node binary, it should stop and print right error log. This patch do it. Additionally this patch add one function to print red color error log.

ISSUE=none

nadongguri commented 6 years ago

@cs-lee, LGTM. Would you share how to fallback to error 2 or 3 cases?

cs-lee commented 6 years ago

case 2 :

1. Delete third_party/node , third_party/mongodb (For download binary again)
1. Disconnect lane cable and do ./absolute test

case 3 :

If sync_third_party.sh - sync_node this function send invalid file url to sync_third_party function. tar or unzip command will fail.

cs-lee commented 6 years ago

@romandev I applied your review comments. Please review.