lundberg / respx

Mock HTTPX with awesome request patterns and response side effects 🦋
https://lundberg.github.io/respx
BSD 3-Clause "New" or "Revised" License
602 stars 39 forks source link

Adjust fake ipv6 in tests to follow specification #231

Closed frantisekz closed 1 year ago

frantisekz commented 1 year ago

Makes the testsuite pass with httpx 0.24 (which otherwise fails on verification as the previous value didn't use eg. :: or hex chars)

I'd used ipv6 for local, not sure if it has any unwanted implications?

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (42930fc) 100.00% compared to head (9aef400) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #231 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 2755 2755 Branches 417 417 ========================================= Hits 2755 2755 ``` | [Impacted Files](https://app.codecov.io/gh/lundberg/respx/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Lundberg) | Coverage Δ | | |---|---|---| | [tests/test\_patterns.py](https://app.codecov.io/gh/lundberg/respx/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Lundberg#diff-dGVzdHMvdGVzdF9wYXR0ZXJucy5weQ==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lundberg commented 1 year ago

Noticed this failing test as well, thanks for the PR @frantisekz 👍

lundberg commented 1 year ago

I opened #232 that upgrades CI requirements, could you redirect this PR to merge into the bump-ci branch so that checks passes.

frantisekz commented 1 year ago

I opened #232 that upgrades CI requirements, could you redirect this PR to merge into the bump-ci branch so that checks passes.

Sorry for the delay, redirected :)