Fix chapter 3 typos - Githubissues

lunduniversity / introprog

Teaching material for "Introduction to Programming using Scala" at Lund University, LTH. http://cs.lth.se/pgk/

141 stars 173 forks source link

Fix chapter 3 typos #596

Closed Husenap closed 2 years ago

Husenap commented 2 years ago

Fixed a couple of typos in lab preparations

bjornregnell commented 2 years ago

Thanks for looking into this. Yes if we deprecate underscore then we need to go through the whole compendium and slides as I think they might be in several places... Would be nice if you could investigate the impact before going with a thunk. I think we should properly introduce the term "thunk" in the function week and make a separate slide on that. https://en.wikipedia.org/wiki/Thunk

Husenap commented 2 years ago

How about I leave it out of this PR and only keep the typo fixes, then I can create an issue where we can discuss it further?

bjornregnell commented 2 years ago

Yes, good to separate typos and the longer stuff!

bjornregnell commented 2 years ago

There are alot of formatting changes, so it is easy to miss other changes when reviewing. Are all the indents from the original file? Usually I dont use indents in the latex code as there are often unwanted side effects of those...

bjornregnell commented 2 years ago

Ah. I was looking at an old page - now when refreshing the GitHub view in browser the changes look nicer and only a few. Cool!

bjornregnell commented 2 years ago

Looks Good To Me.