search

lunduniversity / templates

Lund University templates for documents and projects.
13 stars 6 forks source link

Hide LU foot-note logo on the title page. #4

Closed Xaldew closed 7 months ago

Xaldew commented 4 years ago

Hello,

I noticed that the LU logo was still visible on the title page, despite being mostly hidden by the LU sigil. This change fixes that.

pierremoreau commented 2 years ago

It would be nice to hide it on section title slides too: that can be done by adding \setbeamertemplate{background}{} right after this line.

pierremoreau commented 2 years ago

Actually, the following might be better as it handles both the title and section title frames:

  \ifbeamer@plainframe%
  \else
    \ifulund@printlogo
      … % existing block content
    \fi
  \fi

That will remove the logo from all frames with the plain option, which is probably what one would expect.

bjornregnell commented 8 months ago

I requested a review by you @StefanHost - are you willing to review and test this?

@Xaldew : Did you take the proposal by @pierremoreau into account?

@pierremoreau : Have you tested it and perhaps you can a reviewer and approve if this PR ok?

pierremoreau commented 8 months ago

Given the time-frame from my comments, I probably used for my defence presentation. I could only found the final result and not the source code for it, so I can not confirm. unfortunately.

bjornregnell commented 8 months ago

Aha! OK sorry for reviving very old comments @pierremoreau :)

@StefanHost are you willing to review. Or else, should I just merge Gustav's contrib into your code? (Looks good to me, but it seems as if Pierre's comments are nice to consider...)

pierremoreau commented 8 months ago

No worries, Björn! It is good that someone is pushing for those changes to be made, otherwise they will just be completely forgotten. :+1: I will ping Gustaf about the changes; maybe he had a chance to try those out in a recent presentation.

Xaldew commented 6 months ago

Hello,

I had to dig quite a bit to figure out the original context to this commit (I mean, it's bean almost 5 years now), but as far as I can tell this issue only arise on the title slide if the frame is not marked as [plain] (something that most people probably won't actually do).

That is, without the original commit you would get the LU sigil overlapping with the small logo in the footer. Admittedly, there's still a line in the footer that crosses the sigil, but I guess I didn't see/mind that at the time.

As such, I don't think @pierremoreau 's suggested changes would have any effect, unless it is desired to also remove the sigil itself, at least if I have understood things correctly.

bjornregnell commented 6 months ago

Ok thanks for input @Xaldew - Anyways @StefanHost has apporved and I have merged so if any problems remains open another issue/PR. Otherwise I'll leave it for now.