search

lune-org / lune

A standalone Luau runtime
https://lune-org.github.io/docs
Mozilla Public License 2.0
350 stars 80 forks source link

Please add to the FS API (Metadata) #251

Open bbslipers opened 1 week ago

bbslipers commented 1 week ago

Please add to Metadata for files: size and MD5.

CompeyDev commented 1 week ago

Size is possible to add, but I don't see why we would want to add MD5 hashes. The filesystem itself returns no data for hashing, so we'd need to calculate it ourselves - which doesn't make much sense when you can just use serde.hash.

Do note that serde itself does not contain the MD5 algorithm on purpose, since it's insecure and prone to hash collisions.

bbslipers commented 1 week ago

Thanks for the reply. You are absolutely right about MD5 hashes. I was out of my depth.