search

lune-org / lune

A standalone Luau runtime
https://lune-org.github.io/docs
Mozilla Public License 2.0
350 stars 80 forks source link

Passing flags to `lune run` is not ergonomic #253

Open Nicell opened 1 week ago

Nicell commented 1 week ago

Currently to pass flags to scripts from lune run, you must add a -- before your arguments to make sure they're passed to the underlying script. This is inconvenient. There's only one flag for lune run, --help, which isn't all the helpful if you already know how to pass a script, so it seems unnecessary to swallow all flags.

One possible solution to this is to forward flags on to the script if a script is provided. We could possibly be even more strict and say any flags after the script argument are forwarded on. This would prevent any Lune specific flags being added on in the future for lune run, but it seems unlikely that'd be needed, and this change would be a nice value add.

filiptibell commented 1 week ago

Seems reasonable to me to remove flag parsing altogether for anything passed after run and pass it to process.env - if a user is running lune run they probably already know how it works and don't need --help. Since it's a breaking change it would be a good opportunity to do it for 0.9.0 which is coming up soon

CompeyDev commented 3 days ago

I'd be against removing --help altogether since there is a possibility of us adding flags like --unsafe for FFI.

Not parsing flags after the script path as Lune options sounds reasonable though.