search

lunetics-org / LocaleBundle

Locale Bundle for symfony
MIT License
187 stars 76 forks source link

Support PHP >= 7.2.5 #230

Closed hristokpopov closed 1 year ago

hristokpopov commented 1 year ago

Branch 3.x works fine with the following PHP versions >= 7.2.5

I have done some testing with the following fork: https://github.com/hristokpopov/LocaleBundle/tree/php7

phpunit tests seem to pass as well. A few warnings are generated, but they are not related to the php version.

PHP >= 7.2.5 matches the version needed for Symfony 5.4: https://symfony.com/releases/5.4

Would it be possible to change the PHP requirement in composer.json to: "php": ">=7.2.5"

goetas commented 1 year ago

if you can create a merge request and make the CI green, I do not see issues with it

hristokpopov commented 1 year ago

The PHP requirement was changed to >= 7.2.5: https://github.com/lunetics-org/LocaleBundle/pull/231