lunetics / TimezoneBundle

A Symfony2 Bundle for Serverside Timezone detection
26 stars 11 forks source link

Symfony 2.5 BC break: Validator class #11

Closed maks-rafalko closed 10 years ago

maks-rafalko commented 10 years ago

Hi,

after upgrading to Symfony 2.5.0, I get the following error:

Catchable Fatal Error: Argument 4 passed to Lunetics\TimezoneBundle\EventListener\TimezoneListener::__construct() must be an instance of Symfony\Component\Validator\Validator, instance of Symfony\Component\Validator\Validator\LegacyValidator given

This is because @validator service returns LegacyValidator class.

I see that master branch already uses ValidatorInterface in this constructor. Could you please create a new tag with fixed version? 2.1.1 branch has this bug.

Thank you

maks-rafalko commented 10 years ago

ping @lunetics

wodka commented 10 years ago

for reference: this was fixed in #10 - new stable tag would be nice.

maks-rafalko commented 10 years ago

ping @lunetics Please review. I see you were active some weeks ago :)

lunetics commented 10 years ago

tagged new release 2.1.2

maks-rafalko commented 10 years ago

thx