search

luni64 / VisualTeensy

VisualCode projects for PJRC Teensy boards
Other
116 stars 11 forks source link

Fixed Spelling And Linking Command Errors #69

Closed Michael2MacDonald closed 2 years ago

Michael2MacDonald commented 2 years ago

Fixed the spelling of a message on line 180 Sucessfully built project -> Successfully built project

luni64 commented 2 years ago

Thanks a lot. Since I'm using vsTeensy on a daily basis I wonder under what conditions this generated an issue? Anyway, I'll test it for a couple of days and pull it in if it doesn't generate other issues.

Michael2MacDonald commented 2 years ago

I did find that weird. I have been using v1.2 for a while and don't remember having any issues until now. I did make changes to the makefile, I added a another folder 'os' along with lib, core, and src and put some defines in an external 'config' makefile, but I don't see why that would cause the error to pop up now. I can look into it a little more later.

All the other commands have quotes and adding them to the commands under "Linking" fixed my issue so I thought I would create a pull request with the change.

luni64 commented 2 years ago

Sounds weird indeed. Anyway, I don't think that the risk of breaking something is huge with the quotes. So, if it helps lets include them... I'll play around at the weekend with different configurations. Especially paths with spaces tend to make problems. I thought to have replaced them all with the old 8.3 filenames but I might have forgotten one.

luni64 commented 2 years ago

Thanks again