luniehq / lunie

Lunie is staking, simplified ✨
https://lunie.io
Apache License 2.0
279 stars 98 forks source link

Still showing shares instead of tokens #2048

Closed fedekunze closed 5 years ago

fedekunze commented 5 years ago

Describe the bug A clear and concise description of what the bug is.

Page validator (and maybe LiValidator) is showing shares

To Reproduce Steps to reproduce the behavior:

  1. Submit delegation with X stake
  2. Go to Validator page

REST Request: {"type":"auth/StdTx","value":{"msg":[{"type":"cosmos-sdk/MsgDelegate","value":{"delegator_addr":"cosmos160a2xkrnhk9tqfzklgrwv8nvlplxaa3eegmuz6","validator_addr":"cosmosvaloper160a2xkrnhk9tqfzklgrwv8nvlplxaa3euu0fwf","value":{"denom":"stake","amount":"200001"}}}],"fee":{"amount":null,"gas":"500000"},"signatures":null,"memo":""}

Expected behavior A clear and concise description of what you expected to happen.

Show tokens instead of shares

Screenshots If applicable, add screenshots to help explain your problem.

My Delegation is showing shares:

screen shot 2019-02-21 at 6 27 03 pm
faboweb commented 5 years ago

I don't think this is true. We use the computed yourVotes which calculates shares to tokens. Maybe you thought this because of the uatoms?

fedekunze commented 5 years ago

100200001 uatoms are not 200001 atoms

faboweb commented 5 years ago

100200001 includes the string 200001. this may have been an optimistic update error at the same. I can't reproduce the issue on fabo/2044-big-numbers

Steps:

faboweb commented 5 years ago

@fedekunze changes are on develop now, this should be fixed. can you approve?

fedekunze commented 5 years ago

fixed on develop