luniehq / lunie

Lunie is staking, simplified ✨
https://lunie.io
Apache License 2.0
279 stars 100 forks source link

Inactive validators shown in Restake lists #3876

Closed Bitcoinera closed 4 years ago

Bitcoinera commented 4 years ago

Describe the bug

When you are on the Restake modal, you get a complete list of validators in the "To" dropdown menu, also including inactive validators.

To Reproduce

Try restaking and check on another tab if the validators are active or not. Some are not.

Especially easy to check in testnets, as there many are not active anymore

Expected behavior

The validators list to restake to should only contain active validators

Bitcoinera commented 4 years ago

Leaving this open as a reminder that we need to rewrite the validators dropdown on Restake modal.

There should be something (maybe a color?) to indicate if a validator is active or inactive

jbibla commented 4 years ago

i don't think this is a bug. sometimes, a user may want to stake to an inactive validator to help them become an active validator.

strongly agree we should improve the list and make it visible. i think the plan is to use the existing li-validator components. something like this: https://www.sketch.com/s/Oy9lm/a/GaKa5L

Bitcoinera commented 4 years ago

something like this: https://www.sketch.com/s/Oy9lm/a/GaKa5L

Oh, I love the design 🤩

Bitcoinera commented 4 years ago

Sometime, right?