lunit-io / insight-viewer

medical image viewer component for React
https://insight-viewer.lunit.io
MIT License
34 stars 6 forks source link

VIEWER-138 / Apply renewal AnnotationOverlay to Annotation, Measurement dev docs #390

Closed LTakhyunKim closed 1 year ago

LTakhyunKim commented 1 year ago

๐Ÿ“ Description

Annotation, Measurement ํ†ตํ•ฉ Overlay ๋ฅผ Annotation, Measurement Dev docs ์— ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. ์ด๋ฅผ ํ†ตํ•ด ํ™•์ธํ•˜๊ณ ์ž ํ•˜๋Š” ์‚ฌํ•ญ์€ ๋‹ค์Œ๊ณผ ๊ฐ™์Šต๋‹ˆ๋‹ค.

1. ์‹ค์ œ v6 ์„ ์‚ฌ์šฉํ•œ ์œ ์ €๊ฐ€ v7 ๋กœ migration ํ•  ๋•Œ ์–ด๋–ค ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ•ด์•ผํ•˜๋Š”์ง€?
2. ์ˆ˜์ • ์ „, ํ›„ ๋™์ž‘์ด ๋™์ผํ•œ์ง€? - ์ด๋Š” Cypress Test code ๋กœ ํ™•์ธ

1 ์„ ํ†ตํ•ด ์–ป์€ ๋ฐ์ดํ„ฐ๋Š” ์ฐจํ›„ ์ถ”๊ฐ€๋  public docs ํ˜น์€ confluence ๋ฅผ ํ†ตํ•ด ์ •๋ฆฌ ๋ฐ ๊ณต์œ ํ•  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค.

โœ”๏ธ PR Type

What kind of change does this PR introduce?

๐ŸŽฏ Current behavior

๊ธฐ์กด์— ์กด์žฌํ•˜๋˜ AnnotationOverlay, MeasurementOverlay ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ Annotation, Measurement Viewer, Drawer ๋ฅผ ๊ตฌ์„ฑํ•ฉ๋‹ˆ๋‹ค.

Issue Number: https://lunit.atlassian.net/browse/VIEWER-138

๐Ÿš€ New behavior

ํ†ตํ•ฉ๋œ AnnotationOverlay ๋ฅผ ์ ์šฉํ•ฉ๋‹ˆ๋‹ค. Annotation, Measurement ๋ฅผ ๊ตฌ๋ถ„ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

Annotation, DrawableAnnotation type ์„ export ํ•ฉ๋‹ˆ๋‹ค. 15ddbce (์‚ฌ์šฉ ์šฉ๋„๊ฐ€ ์žˆ์–ด, export ์— ํฌํ•จํ•˜์˜€์Šต๋‹ˆ๋‹ค.)

AnnotationOverlay ๋ฅผ Annotation dev docs ์— ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. 3cdf5f9

AnnotationOverlay ๋ฅผ Measurement dev docs ์— ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. 6a73fdb

๐Ÿ’ฃ Is this a breaking change?

github-actions[bot] commented 1 year ago

preview: https://insight-viewer--pr-390.f.lunit.io/

deminoth commented 1 year ago

Annotation, Measurement ํ†ตํ•ฉ Overlay ๋ฅผ Annotation, Measurement Dev docs ์— ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.

๊ทธ๋Ÿฌ๋ฉด CombinedOverlay ๋Š” ์‚ญ์ œํ•ด๋„ ๋˜์ง€ ์•Š์„๊นŒ์š”?

LTakhyunKim commented 1 year ago

๊ทธ๋Ÿฌ๋ฉด CombinedOverlay ๋Š” ์‚ญ์ œํ•ด๋„ ๋˜์ง€ ์•Š์„๊นŒ์š”?

๋„ต ์‚ญ์ œํ•ด๋„ ๊ดœ์ฐฎ์Šต๋‹ˆ๋‹ค. combined overalay page ์‚ญ์ œ ๋ฐ ๋„ค๋น„๊ฒŒ์ด์…˜ ํ•ญ๋ชฉ์—์„œ ์ œ์™ธ ํ–ˆ์Šต๋‹ˆ๋‹ค. 16251d8