lunixbochs / revsync

realtime cross-tool collaborative reverse engineering
MIT License
100 stars 25 forks source link

RFC: Remove structs & stackvars from binja_frontend #11

Closed zackorndorff closed 2 years ago

zackorndorff commented 2 years ago

Binary Ninja's Structures API changed. I want to have the binja frontend in shape for DC quals, so given I don't have time to get a robust solution for structure sync in by then, I propose disabling the feature for now. (I suspect it really wouldn't take that long to get it working at least as well as it was before, if anyone's interested in working on it)

I'd be curious if anyone had thoughts on if it'd be worth re-enabling at a later date, as I feel much of the value is obtained via comments / naming. Also, Binary Ninja now has "structs" which are packed and "types" which are not packed. If we're going to be syncing one, we should be syncing both. I'm open to taking a look into it if we feel it's worth it.

Additionally, I'd like to disable the stackvar sync, as the last time I used it, it didn't really do a whole lot beyond clutter up the log. Again, I should note it could probably work with some cleanup (albeit maybe not cross-tool very well).

Broke this out as a separate PR so it can be approved / rejected separately from the other bugfix PR.