search

lunixbochs / struc

Better binary packing for Go
MIT License
567 stars 43 forks source link

Fix conversion of signed integers #58

Closed mewmew closed 6 years ago

mewmew commented 6 years ago

Fixes #57.

Note, this PR should be merged after #56 as I failed to base the branch of master, and instead did if of the prev PR.

mewmew commented 6 years ago

Ok. I think the PR is ready for another round of review. I think I have addressed the comments you made. Let me know if I missed something.