Panic with details for unimplemented features

lunixbochs / struc

Better binary packing for Go

MIT License

576 stars 45 forks source link

Panic with details for unimplemented features #65

Closed 13rac1 closed 5 years ago

13rac1 commented 5 years ago

A better developer experience IMO than the current unexplained errors. Custom tests have "expectPanic" which fail when a panic() doesn't happen.

Comment out panic() and expectPanic bool to work on a feature.

Pulled out of #63

13rac1 commented 5 years ago

I'm fairly sure I'm only panicking for unimplemented features. All existing tests work, but there is a non-zero chance this may cause failures for users of undocumented/untested/undefined features. Probably for the best though, since we'll find out what those are.

13rac1 commented 5 years ago

No response in over two months. Closing.