workflow: Remove record ID and simplify record store

andrewwormald commented 2 weeks ago

The goal of this MR is to simplify workflow a bit. The goal is to reduce mental complexity by removing the ID field for Records. Originally Workflow considers workflow name + foreignID + runID as a unique key for each run. As time has gone on I have thought more and more around the scalability of UUID v4 and the the low collision probability that it has even at the quantillion range is only reaching 50% probability.

Considering this and the desire to simplify the data model I am proposing that the runID is made a globally unique identifier for a workflow run which also aligns it more to it's name of RunID instead of using a combination of workflow name + foreignID + runID.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests, if appropriate.

New Feature Submissions:

[x] Does your submission pass tests?
[x] Did you install pre-commit hooks before committing?

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?