Fix cmake gmp - Githubissues

bredelings commented 4 years ago

Here are some changes to make the --gmp argument work in the install script.

I removed a few other changes before submitting this PR:

make the install script print the cmake command line
remove -Werror
remove -march=native

At some point I had -Werror problems, maybe because gcc-9 found some new errors. I can't remember.

-march=native was causing trouble because different nodes in our cluster support different extended instruction sets.

I used cmake with '-G Ninja' to generate a ninja file instead of a Makefile, and that worked great.

(P.S. If you ever decide that you hate cmake, I recommend taking a look at meson: mesonbuild.com. I really like it, it seems more readable that cmake, and is quite responsive to any bug reports.)

bredelings commented 4 years ago

Fixes #120

bredelings commented 4 years ago

Any problems with this PR? It looks straightforward to me...

dancooke commented 4 years ago

All good. Thanks!

luntergroup / octopus

Fix cmake gmp #122