luntergroup / octopus

Bayesian haplotype-based mutation calling
MIT License
302 stars 38 forks source link

platform.linux_distribution() used in install.py is deprecated since python3.5 and removed since 3.8 #129

Closed DaGaMs closed 4 years ago

DaGaMs commented 4 years ago

Describe the bug ./scripts/install.py -D --sanitize

  File "./scripts/install.py", line 448, in <module>
    main(args)
  File "./scripts/install.py", line 298, in main
    dependencies_dir, dependencies_binaries = install_dependencies(octopus_build_dir)
  File "./scripts/install.py", line 224, in install_dependencies
    brew_bin = install_homebrew(build_dir)
  File "./scripts/install.py", line 163, in install_homebrew
    init_homebrew(brew_bin_dir)
  File "./scripts/install.py", line 153, in init_homebrew
    if is_centos((6,)):
  File "./scripts/install.py", line 85, in is_centos
    dist, dist_version, _ = platform.linux_distribution()

This is due to the is_centos function. FWIW, platform.linux_distribution() has been deprecated: https://docs.python.org/3.5/library/platform.html#platform.linux_distribution

dancooke commented 4 years ago

Resolved in 72d276fb33fa252ddf28887209950d9bd99d2008. Thanks.