luntergroup / octopus

Bayesian haplotype-based mutation calling
MIT License
301 stars 37 forks source link

Switch PS genotype field type to Integer. #134

Closed roryk closed 3 years ago

roryk commented 3 years ago

The VCFv4.3 specification lists this field as an Integer. I ran into this issue trying to merge calls from several callers, the octopus calls disagree with the field type which causes problems when merging. Thanks so much!

dancooke commented 3 years ago

Thanks! Interestingly, the GIAB truth calls also use String for PS.

roryk commented 3 years ago

Thanks Dan! There needs to be a github for data where I could PR the fix for them too. :)