search

luntergroup / octopus

Bayesian haplotype-based mutation calling
MIT License
302 stars 38 forks source link

cmake3 note found on CentOS #37

Closed lachlansimpson closed 5 years ago

lachlansimpson commented 5 years ago

Describe the bug Install fails if it can't find cmake of version.

Only searches for cmake.

In CentOS - and I presume RedHat - cmake is used for version 2, cmake3 is for version 3.

Need to edit line 98 of scripts/install.py from

ret = call(["cmake"] + cmake_options + [".."])

to

ret = call(["cmake3"] + cmake_options + [".."])

and that check passes.

dancooke commented 5 years ago

Thanks. I didn't know this CMake naming convention in CentOS. I'll modify the script to try both versions.

dancooke commented 5 years ago

Addressed in 30a3ffb11ad216e108efefcd70549130939655bb and is available on develop branch. Please re-open if any issues.