search

luntergroup / smcsmc

Demographic inference from whole genomes
GNU General Public License v3.0
11 stars 4 forks source link

scrm_input maximum number of arguments #61

Closed DonnaHenderson closed 7 years ago

DonnaHenderson commented 7 years ago

Hey Joe,

Could we get rid of the kMaxArgs at https://github.com/luntergroup/smcsmc/blob/master/src/pfparam.cpp#L284 or at least increase it substantially? I find in situations with migration I hit that maximum fairly easily. Do you remember why you chose 264 for this value and if it is necessary?

Thanks!

shajoezhu commented 7 years ago

Hi Donna

Yes, we can change this number to 1024. I don't recall there was any particular reason for using 264.

best joe

shajoezhu commented 7 years ago

Hi Donna

Assume this is working?

best joe

DonnaHenderson commented 7 years ago

Yes, I accepted your pull request and checked it now accepts longer command strings. Thanks!

On 6 Apr 2017, at 07:40, Joe Zhu notifications@github.com<mailto:notifications@github.com> wrote:

Hi Donna

Assume this is working?

best joe

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/luntergroup/smcsmc/issues/61#issuecomment-292083175, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIoYz1t54SQTgtoy9LJm895eAmq7yabQks5rtIjggaJpZM4My7VD.