search

luochen1990 / rainbow

Rainbow Parentheses Improved, shorter code, no level limit, smooth and fast, powerful configuration.
Apache License 2.0
1.78k stars 95 forks source link

docs(readme): fix conflict with NERDTree #185

Closed timsu92 closed 1 year ago

timsu92 commented 2 years ago

Sorry, I've forgot where did I found this, so I can't provide the link to the issue.

timsu92 commented 2 years ago

I guess this is how it caused: I have nerdtree-git-plugin installed, which shows the [ ] parentheses(bracket?) by default. Originally, there's an option in that plugin to disable this. However, I have vim-devicons installed as well. As the readme indicates, I can't disable them. And then, rainbow changes the color, so they aren't concealed.

luochen1990 commented 1 year ago

Thanks, this LGTM, and it would be better if the Chinese comment translated into English, so that this plugin will cause less problems in systems where unicode is poorly supported.

timsu92 commented 1 year ago

One of the file is README.md while the other one is suffixed with zh, which means Chinese. So I think people who open that file should be prepared to see the characters.

BTW, contents in README.md and README_zh.md are inconsistent.

luochen1990 commented 1 year ago

Oh, it's in README_zh.md, then it's not a problem.

BTW, contents in README.md and README_zh.md are inconsistent.

Yes, they are not expected to be consistent in each line, but their main part should be consistant. If not, please tell me.

timsu92 commented 1 year ago

their main part should be consistant. If not, please tell me.

Sorry but if you can read Chinese, it might be better to just see what's happening. I wanted to list all the differences. Sadly, however, there are just too many😢

Nevertheless, I guess current status is still controllable as many of the differences show that English version is better.

Lastly, thanks for creating this! I really appreciate this work! It saves much of my time from making sure in which parenthesis I'm working!