Fix test_noipstyle_incorrect failed on Windows

YanWQ-monad commented 4 years ago

在 Windows 上运行 cyaron 测试，会出现如下错误：

======================================================================
FAIL: test_noipstyle_incorrect (cyaron.tests.compare_test.TestCompare)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "F:\Github\cyaron\cyaron\tests\compare_test.py", line 52, in test_noipstyle_incorrect
    Compare.output("test_another_incorrect.out", std=io)
cyaron.compare.CompareMismatch: In program: 'test_another_incorrect.out'. On line 2 column 7, read 4, expected 3.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "F:\Github\cyaron\cyaron\tests\compare_test.py", line 56, in test_noipstyle_incorrect
    self.assertEqual(e.content, 'test123\r\ntest124 ')
AssertionError: 'test123\r\r\ntest124 ' != 'test123\r\ntest124 '
+ test123
?         +
-
  test124

其原因是在 Windows 上的换行方式默认为 CRLF，以非二进制方式打开的文件中，写入的 \n 字符都将会被替换为 \r\n 字符。

https://github.com/luogu-dev/cyaron/blob/4c54f89265e7d4ed57fc7f7515b3befdcc474a07/cyaron/tests/compare_test.py#L32-L33

所以在测试用例中，写入 test123\r\ntest124 实际上会写入 test123\r\r\ntest124。

修复方式为用二进制方式打开文件，再写入。

william-song-shy commented 4 years ago

有毒的Windows 为什么要有回车符/r

---Original--- From: "Monad"notifications@github.com Date: Sun, Jul 28, 2019 22:31 PM To: "luogu-dev/cyaron"cyaron@noreply.github.com; Cc: "Subscribed"subscribed@noreply.github.com; Subject: [luogu-dev/cyaron] Fix test_noipstyle_incorrect failed on Windows (#67)

在 Windows 上运行 cyaron 测试，会出现如下错误： ====================================================================== FAIL: test_noipstyle_incorrect (cyaron.tests.compare_test.TestCompare) ---------------------------------------------------------------------- Traceback (most recent call last): File "F:\Github\cyaron\cyaron\tests\compare_test.py", line 52, in test_noipstyle_incorrect Compare.output("test_another_incorrect.out", std=io) cyaron.compare.CompareMismatch: In program: 'test_another_incorrect.out'. On line 2 column 7, read 4, expected 3. During handling of the above exception, another exception occurred: Traceback (most recent call last): File "F:\Github\cyaron\cyaron\tests\compare_test.py", line 56, in test_noipstyle_incorrect self.assertEqual(e.content, 'test123\r\ntest124 ') AssertionError: 'test123\r\r\ntest124 ' != 'test123\r\ntest124 ' + test123 ? + - test124
其原因是在 Windows 上的换行方式默认为 CRLF，以非二进制方式打开的文件中，写入的 \n 字符都将会被替换为 \r\n 字符。

   cyaron/cyaron/tests/compare_test.py     

     Lines 32 to 33       in       4c54f89     

                                      with open("test_another.out", "w") as f:          
                                f.write("test123\r\ntest123 ")

所以在测试用例中，写入 test123\r\ntest124 实际上会写入 test123\r\r\ntest124 。

修复方式为用二进制方式打开文件，再写入。

You can view, comment on, or merge this pull request online at:

https://github.com/luogu-dev/cyaron/pull/67

Commit Summary

Fix test_noipstyle_incorrect failed on Windows
File Changes

 M     cyaron/tests/compare_test.py     (4)

Patch Links:

https://github.com/luogu-dev/cyaron/pull/67.patch
https://github.com/luogu-dev/cyaron/pull/67.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

YanWQ-monad commented 4 years ago

这个是历史遗留问题吧

luogu-dev / cyaron

Fix test_noipstyle_incorrect failed on Windows #67