luomus / laji

Frontend for Finnish Biodiversity Information Facility (FinBIF) data portal laji.fi (and other *.laji.fi frontends)
MIT License
7 stars 0 forks source link

Stricter ts config #586

Open olzraiti opened 4 hours ago

olzraiti commented 4 hours ago

Stricter typing would have many benefits: less bugs since the code is constructed better, less null pointer errors, easier coding since the methods are properly typed.

We can migrate the old code gradually. PR size should be max ~one day worth of work. Just add type any if you don't know what the exact type is - this way the old code won't be any worse typed than it is now, and in the future when we get the strict typing to be the default, new code will have improved typings.

All developers are committed to this. Everybody has their own day when they work on this for as long as want to.

Monday: @Blodir Tuesday: @rpulkka Wednesday: @aorin Thursday: @MLumme Friday: @olzraiti

Dev instructions:

  1. Run app with strict mode npm run start:strict
  2. Replace tsconfig.json with tsconfig.app-strict.json
olzraiti commented 3 hours ago

4864 errors currently