search

luox-app / luox

Code base for the luox platform
https://luox.app/
GNU General Public License v3.0
15 stars 11 forks source link

About page edits and addition of CITATION file #30

Closed floehopper closed 3 years ago

floehopper commented 3 years ago

@spitschan:

I've just fixed the build on this about-page branch. The build errors were to do with some linter checks that we run. At the moment they run against the markdown files to enforce some useful opinionated formatting rules and the build will fail if the rules are violated.

The prettier command line tool can be used to automatically fix many violations and this is indeed what I did to fix the build errors on your branch in this commit (https://github.com/freerange/lightbox/commit/ccf9c8e92ded6b6f39138ad7e9796133d1279ba1).

If we want to make it easier for you to make this kind of change independently it might make sense to exclude this markdown file from the prettier linter checks, although the linter checks are potentially useful. Let me know what you think.

I've opened this pull request in order that a deploy preview is created by Netlify so you can preview the changes you've made. If you're happy, you could either click the "Merge" button yourself or ping us in Slack and one of us can merge it for you. Merging will automatically deploy the changes to the actual production site as long as there are no build errors.

floehopper commented 3 years ago

@spitschan The deploy preview can be found here