luox-app / luox

Code base for the luox platform
https://luox.app/
GNU General Public License v3.0
14 stars 11 forks source link

Make sharing link more discoverable #32

Closed floehopper closed 3 years ago

floehopper commented 3 years ago

This branch contains a couple of ideas I tried out to make the sharing link more discoverable as per this Trello card. The work isn't completely finished, but it would be useful to have feedback on whether any of the changes seem sensible...

Screenshot 2021-01-22 at 16 56 59

TODO:

floehopper commented 3 years ago

@spitschan You can preview these changes here.

floehopper commented 3 years ago

I've just pushed up changes to address the following:

TODO:

  • The copy link button and its handler should probably be converted into a React component.

While I haven't actually turned the button into a React component - I've made the code a lot more React-y and I think it's fine for now.

  • The text of the copy link button should probably revert after a certain amount of time, so it's obvious you can click it again.

The button text now reverts to "Copy to clipboard" after 1 second. Also while the text says "Copied!" the button is disabled.

floehopper commented 3 years ago

I've now pushed up a fix for the following:

TODO:

  • If the data contains less than 5 rows, the ellipsis row should not be displayed.

I'm also not displaying the "Display all rows?" checkbox if there are less than 5 rows, because there aren't any more rows to display!

floehopper commented 3 years ago

I think this is all ready to merge from my point of view and @spitschan has already given it the go ahead here: https://trello.com/c/Az52kTKS/67-make-the-report-sharing-link-more-discoverable#comment-6012bd6f5df1a47cbe84bd6b. So I'm going to get it merged now.