luox-app / luox

Code base for the luox platform
https://luox.app/
GNU General Public License v3.0
15 stars 11 forks source link

Add "Upload" navbar item for /upload page #33

Closed floehopper closed 3 years ago

floehopper commented 3 years ago

Trello: https://trello.com/c/9aER9qp1

This makes the navbar a bit more consistent by including a new item for the "Upload" page.

Screenshot 2021-01-22 at 17 06 26

We might also want to add one for the "Generate CSV" page, but I haven't yet included that change here.

I've opened this PR so the changes can be reviewed.

floehopper commented 3 years ago

@spitschan The changes can be reviewed here.

floehopper commented 3 years ago

@spitschan I've renamed the /generate-csv path to /format-info as you suggested. You can see the changes on this branch here:

I've just done a quick audit of the three main pages and highlighted some inconsistencies and/or things where it would be better to discriminate between pages...

Page 1 / Home page

Page 2

Page 3

The "page title" is the text which appears in a browser tab or a bookmark. Typically it would include both the name of the site and the main heading, e.g. "luox - Upload".

Screenshot 2021-02-01 at 17 55 32

If you can give me any suggestions on any of the above, I'll do my best to fix things.

spitschan commented 3 years ago

Changes:

Page 1 / Home page

Page 2

Page 3

floehopper commented 3 years ago

@spitschan Thanks. I forgot about the About page, but I've made some educated guesses about that. I've made all these changes now and I'm happy enough with them to merge them. Let me know if anything looks odd/wrong.