search

luox-app / luox

Code base for the luox platform
https://luox.app/
GNU General Public License v3.0
14 stars 11 forks source link

Display version info derived from git at build time #34

Closed floehopper closed 3 years ago

floehopper commented 3 years ago

This is an initial stab at displaying version info suitable for https://trello.com/c/1nUvEVXs/86-display-version-information-on-about-page. I did it in a bit of a rush so I might've made mistakes and there might be a more elegant way of doing it...

Screenshot 2021-01-22 at 17 55 42
floehopper commented 3 years ago

@spitschan You can review this here.

spitschan commented 3 years ago

The version tag information and the Upload tab look great, and should be integrated. The version tag needs to harmonise with the revised "About" page on the about-page branch.

I do not see this change:

"Scroll to top for each new page displayed by Router"

What does it mean?

floehopper commented 3 years ago

The version tag information and the Upload tab look great, and should be integrated. The version tag needs to harmonise with the revised "About" page on the about-page branch.

OK. Just to explain the version info a bit more:

However, a commit SHA alone should be sufficient to exactly replicate a given state of the codebase.

I'll look at getting this combined with the work you've done on the About page and get it merged.

floehopper commented 3 years ago

I do not see this change:

"Scroll to top for each new page displayed by Router"

What does it mean?

This is explained in https://github.com/luox-app/luox/pull/31 and you can see a preview of that change from the link in that pull request.

spitschan commented 3 years ago

Yes, I saw the explanation but didn’t understand it as I couldn’t reproduce or imagine the behaviour you mentioned. Anyway, happy to roll out

From: James Mead notifications@github.com Reply to: luox-app/luox reply@reply.github.com Date: Monday, 1 February 2021 at 15:38 To: luox-app/luox luox@noreply.github.com Cc: Manuel Spitschan mspits@sas.upenn.edu, Mention mention@noreply.github.com Subject: Re: [luox-app/luox] WIP: Experiment to display version info derived from git at build time (#34)

I do not see this change:

"Scroll to top for each new page displayed by Router"

What does it mean?

This is explained in #31https://github.com/luox-app/luox/pull/31 and you can see a preview of that change from the link in that pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/luox-app/luox/pull/34#issuecomment-770946969, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZPZ35QE5OE6YDFJ6ERIIDS43DGXANCNFSM4WO2EZSA.