search

luox-app / luox

Code base for the luox platform
https://luox.app/
GNU General Public License v3.0
14 stars 11 forks source link

Update Intro.jsx #40

Closed spitschan closed 3 years ago

floehopper commented 3 years ago

@spitschan

The reason this didn't work is that you were changing HTML inside a JSX file which has slight differences from standard HTML. If you want to make a change like this, here are a couple of ideas to try:

Option 1 - Use JSX to add the style inline

<p style={ {fontSize: "20%"} } className="text-center">

Option 2 - Add a unique DOM ID to the element and use a stylesheet rule to apply the style

<p id="welcome-trust-logo-text" className="text-center">

In src/stylesheets/application.scss add:

#welcome-trust-logo-text {
  font-size: 20%
}
floehopper commented 3 years ago

@spitschan I should also have mentioned, we've been trying to use Bootstrap v4 CSS classes to do most of the styling on the site rather than custom styles. It's not a big deal if you add a few custom styles, but if you end up adding quite a few, it might be better to try to use Bootstrap CSS classes.

spitschan commented 3 years ago

Thanks James. I just wanted to reduce the size, and don’t expect any further cosmetic updates immediately.

All the best,

Manuel

From: James Mead notifications@github.com Reply to: luox-app/luox reply@reply.github.com Date: Friday, 5 February 2021 at 09:59 To: luox-app/luox luox@noreply.github.com Cc: Manuel Spitschan mspits@sas.upenn.edu, Mention mention@noreply.github.com Subject: Re: [luox-app/luox] Update Intro.jsx (#40)

@spitschanhttps://github.com/spitschan I should also have mentioned, we've been trying to use Bootstrap v4https://getbootstrap.com/docs/4.5/getting-started/introduction/ CSS classes to do most of the styling on the site rather than custom styles. It's not a big deal if you add a few custom styles, but if you end up adding quite a few, it might be better to try to use Bootstrap CSS classes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/luox-app/luox/pull/40#issuecomment-773927942, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZPZ37GTOJTQBNNSKGPWZ3S5O6OHANCNFSM4XBS2ABQ.