luoxuhai / pcl.js

☁️ ⚡ Point Cloud Library (PCL) for browser, powered by WebAssembly.|在浏览器运行的点云库 (PCL),由 WebAssembly 提供支持。
https://pcl.js.org
MIT License
453 stars 38 forks source link

Added RegionGrowing api and passed all the test cases, but failed to run it in browser | 增加了RegionGrowing的扩展,也通过了测试用例,但是浏览器里跑不起来 #122

Closed whichones-pink closed 1 year ago

whichones-pink commented 1 year ago

Is there an existing issue for this?

Package Version

extension based on 1.16.0

Current Behavior

When running in browser, all the class we added are not loaded into the PCLCore. 跑在浏览器的时候,暴露出来的一系列类都没加载到PCLCore里面。

image

Expected Behavior

PCLCore should look like the following(pcl.js v1.16.0) image

Steps To Reproduce

check my code here diffs Just build it and use the new-built pcl-core.wasm and pcl.js

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

whichones-pink commented 1 year ago

I made a stupid mistake here that I replaced my node_modules pcl.js and wasm with the new build one. Although my project hot reloaded, the code changes are not detected. So can I sumbit a PR now?

luoxuhai commented 1 year ago

Thanks!