lupidan / apple-signin-unity

Unity plugin to support Sign In With Apple Id
MIT License
598 stars 85 forks source link

Support for VisionOS #188

Open snowyao opened 10 months ago

snowyao commented 10 months ago

Any plan for VisionOS support?

derwaldgeist commented 9 months ago

Bump. I'd also like to see this.

There's a couple of lines in the code where only iOS, tvOS and macOS are being checked for. I guess if these lines were modified to include visionOS as well, it might work out-of-the-box.

derwaldgeist commented 9 months ago

Ok. I tried to patch the library in my fork:

https://github.com/marblear/apple-signin-unity/tree/visionos

Turns out that modifying the OS-specific conditional compilations was not enough. It seems as if the PolySpatial app delegate has to be patched as well. I get a runtime error that it does not accept a certain selector.

lupidan commented 8 months ago

My 2019 Macbook does not support the VisionOS simulator...

Screenshot 2024-01-21 at 12 34 41
derwaldgeist commented 8 months ago

Yep. I actually had to get an M3 macBook just to do that. Which is silly, but was the only way.

delphinius81 commented 6 months ago

Ok. I tried to patch the library in my fork:

https://github.com/marblear/apple-signin-unity/tree/visionos

Turns out that modifying the OS-specific conditional compilations was not enough. It seems as if the PolySpatial app delegate has to be patched as well. I get a runtime error that it does not accept a certain selector.

Are you suggesting that Unity needs to make some kind of change? Do you have any further details (remember what the specific error was / have a stack trace?)

ChuanlongChen commented 6 months ago

Same request, marked

ChuanlongChen commented 6 months ago

Hey guys, I've successfully make it works in VisionOS, but seems I can't create PR for this repo, I modify it in my own fork. Here is the PR: https://github.com/ChuanlongChen/apple-signin-unity/pull/1 You can consider integrate my modifications to this repo too.

FYI @lupidan @snowyao @derwaldgeist @delphinius81

ChuanlongChen commented 6 months ago

Update: I'm able to create PR for this repo https://github.com/lupidan/apple-signin-unity/pull/198

ChuanlongChen commented 5 months ago

@lupidan it would be great if you could take time to review my pr