I discovered recently that the new image assets for Twitter and OpenGraph metadata (added to support #61, implemented in https://github.com/lupinia/awi/commit/0a47b3d708eb8c064402fc9f31e2eb5a7bd4cc72) do not properly contain watermarks. This appears to be because they're getting cut off. I checked the order of operations in sunset.models.image, and the watermark is the first thing being applied, before any resizing. Since setting exact to True causes the build_resize process to crop the image if its aspect ratio doesn't match, this cuts off the watermark.
I'm sure this order of operations made sense at the time that I wrote it, but it's completely backward: Watermarking needs to be the last step in the process, not the first.
I discovered recently that the new image assets for Twitter and OpenGraph metadata (added to support #61, implemented in https://github.com/lupinia/awi/commit/0a47b3d708eb8c064402fc9f31e2eb5a7bd4cc72) do not properly contain watermarks. This appears to be because they're getting cut off. I checked the order of operations in
sunset.models.image, and the watermark is the first thing being applied, before any resizing. Since settingexacttoTruecauses thebuild_resizeprocess to crop the image if its aspect ratio doesn't match, this cuts off the watermark.I'm sure this order of operations made sense at the time that I wrote it, but it's completely backward: Watermarking needs to be the last step in the process, not the first.