search

lupo49 / dokuwiki-plugin-dir

Dir plugin for DokuWiki
http://www.dokuwiki.org/plugin:dir
6 stars 10 forks source link

Use the original Dokuwiki table renderer #26

Closed rexut closed 7 years ago

rexut commented 8 years ago

There is no reason to me, why the original table renderer was ignored here. On the contrary, this approach has led to the counter for table rows was not properly zeroed. The result was a malformed table header (conflicts with the CSS modell).

Signed-off-by: Stephan Linz linz@li-pro.net

michitux commented 8 years ago

This makes it impossible to change the class of the table to ul. In the most recent release of DokuWiki it is possible to supply a custom table class to table_open, but this was not possible before.

Klap-in commented 7 years ago

Since https://github.com/splitbrain/dokuwiki/pull/1558 table_open() of the renderer can be used to set add a custom class. This is change is included in last release of DokuWiki.

Could you update this pull request?

gjanssens commented 7 years ago

I have merged this PR and added a follow up commit to set the table class as it used to be with the custom table renderer. Thanks!