lupomontero / psl

JavaScript domain name parser based on the Public Suffix List
https://www.npmjs.org/package/psl
MIT License
383 stars 77 forks source link

punycode is deprecated in Node v21 #315

Open AnWeber opened 11 months ago

AnWeber commented 11 months ago

Using punycode is deprecated in Node v21. See documentation https://nodejs.org/api/punycode.html. Maybe try replacing with NPM Package punycode

punycode is used here: https://github.com/lupomontero/psl/blob/797ccb41136a75b5737ea1e4d2bdcaad0dac02de/index.js#L5

Fix:

  1. npm i punycode
  2. change from require("punycode") to require("punycode/")

https://github.com/AnWeber/httpyac/issues/577

AnWeber commented 11 months ago

There is already a pull request from 2022 fixing this issue.

298

quinton-ashley commented 9 months ago

@lupomontero

ryuujo1573 commented 8 months ago

https://github.com/lupomontero/psl/commit/3ddec00372501a4657d28fbd87e6fd59db12a897 See this commit and it may suggest that new version be released soon.

jm42 commented 7 months ago

This is already fixed. We are just waiting for a new release. Patience is a virtue.

MikeMcC399 commented 7 months ago

@jm42

This is already fixed. We are just waiting for a new release. Patience is a virtue.

Can you clarify why you suggest just waiting? Are you a maintainer and you are planning a release?

It's 2 months ago since @lupomontero added a series of commits into the master branch including the fix https://github.com/lupomontero/psl/commit/3ddec00372501a4657d28fbd87e6fd59db12a897 for this issue.

If you are not a maintainer, then perhaps @lupomontero could say if/when a new release is planned?

skagedal commented 5 months ago

Thank you for maintaining this package! I understand that it is a lot of work. It would be appreciated with a release that includes thix fix.

NullVoxPopuli commented 1 week ago

when is the next release? it's been almost a year.

thanks!

(also if you want help, I can lend a hand! I manage a fair number of packages) (I know this reads as spam / malicious, I'm sorry, I don't know how to make it sound nicer) image