luqimin / tinylight-vscode

vscode color theme Tiny Light
17 stars 14 forks source link

Color of the key words in Rust is inconsistent #11

Open Scott169 opened 1 month ago

Scott169 commented 1 month ago

Hello! I noticed that the recent versions changed the color of many elements, and I found the colors of some key words were different in newer versions.

I would have a try to fix it by myself and make a pr for it. If you could help fix that would be grateful.

image

luqimin commented 1 month ago

Yes, of cource! Sorry for the late reply.

luqimin commented 1 month ago

I already changed some keyword styles. Please let me know if this fit your needs.

Scott169 commented 1 month ago

Thanks, but there's no change😂

By the way, there's inconsistent of keywords in rendered documentation (color, bold). All these issues are only found in v2.0.0 and later.

image

luqimin commented 1 month ago

Thanks, but there's not change😂

By the way, there's inconsistent of keywords in rendered documentation (color, bold). All these issues are only found in v2.0.0 and later.

image

Can you please give me a code demo, so I can debug directly. Of course, it would be great if you can make a pr 😁

Scott169 commented 1 month ago

How to provide the code demo to you?

I can help debug this issue by comparing v2.0.0 and v0.10.1 to find which elements were changed.

luqimin commented 1 month ago

In my workspace, the snippet looks like this, perhaps some plugin breaks the original style?

image
Scott169 commented 1 month ago

Yes, I noticed that. Maybe it is caused by rust-analyzer. The color is changed when the indexing is finished, see recorded video below:

https://github.com/luqimin/tinylight-vscode/assets/38151815/dd5f045d-12e7-44cd-bdf8-423b5f4a40e0

luqimin commented 1 month ago

Yes, I noticed that. Maybe it is caused by rust-analyzer. The color is changed when the indexing is finished, see recorded video below:

record.mp4

I'm not familiar with rust, rust-analyzer runs failed in my worspace 😂

ERROR rust_analyzer::main_loop: FetchWorkspaceError:rust-analyzer failed to load workspace