search

luqmana / rust-opencl

OpenCL bindings for Rust.
Other
170 stars 42 forks source link

Add OpenCL 1.1 extensions #54

Closed kazimuth closed 9 years ago

kazimuth commented 9 years ago

...at least, the non-OpenGL ones.

I've almost certainly made mistakes transcribing the things from cl_ext.h, but I can't find any more of them.

Partially addresses #52.

eholk commented 9 years ago

I just tried to build this and got a bunch of errors like this:

/Users/eholk/Documents/projects/rust-opencl/src/ext.rs:49:29: 49:33 error: Sync is an unsafe trait and it should be implemented explicitly
/Users/eholk/Documents/projects/rust-opencl/src/ext.rs:49     () => (#[deriving(Copy, Sync)] pub struct Functions;);
                                                                                      ^~~~

Would you mind updating this. I think these are just changes that have happened in Rust recently.

Also, I didn't see any tests in there. It'd be nice to have some to make sure the code keeps running. They don't have to be real involved, maybe just try to load a common extension to exercise the code.

kazimuth commented 9 years ago

Done! The test currently just tries to load all the implemented extensions - it doesn't actually care if they do load or not, though.

eholk commented 9 years ago

Awesome, thanks!