search

lurdan / ob-typescript

Emacs org-mode babel support for typescript
GNU General Public License v3.0
31 stars 12 forks source link

version check doesn't use org-babel-command #7

Closed ErikaKuykendall closed 8 months ago

ErikaKuykendall commented 8 months ago

https://github.com/lurdan/ob-typescript/blob/abf36f1f3b2476e71c63721dc907d7e6914aef3d/ob-typescript.el#L65

get-tsc-version hardcodes a call to tsc rather than using the user-configurable org-babel-command:typescript, which breaks the ability to use the package without globally installing typescript

lurdan commented 8 months ago

lgtm, thanks.